d243dce027
- Replaced manual remote client functions with remote_client! macro for archive, blame, branch, commit, and diff services - Simplified remote client creation logic using declarative macro approach - Maintained same functionality while reducing code duplication across services security(bare): enhance path traversal protection with comprehensive validation - Added early relative_path validation to prevent path traversal attacks - Implemented unified path validation to avoid TOCTOU race conditions - Enhanced canonicalization checks for both existing and non-existent paths - Added detailed logging for path traversal detection attempts feat(cache): migrate from CLruCache to Moka with TTL and invalidation support - Replaced clru dependency with moka for improved caching capabilities - Added 300-second time-to-live for cache entries - Implemented repository-specific cache invalidation mechanism - Enhanced cache operations with thread-safe async support refactor(commit): improve security validation for commit operations - Added ref name validation to prevent command injection in cherry_pick_commit - Implemented revision validation for commit selectors - Added comprehensive input validation for create_commit parameters - Enhanced file path validation to prevent traversal
140 lines
5.4 KiB
Rust
140 lines
5.4 KiB
Rust
use crate::pb::tag_service_client::TagServiceClient;
|
|
use crate::pb::*;
|
|
|
|
use super::{GitksService, into_status};
|
|
|
|
remote_client!(remote_tag_client, TagServiceClient<tonic::transport::Channel>, "tag");
|
|
|
|
#[tonic::async_trait]
|
|
impl tag_service_server::TagService for GitksService {
|
|
async fn list_tags(
|
|
&self,
|
|
request: tonic::Request<ListTagsRequest>,
|
|
) -> Result<tonic::Response<ListTagsResponse>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let span = tracing::info_span!("tag.list_tags", %repo);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_tag_client(self, inner.repository.as_ref(), false).await?
|
|
{
|
|
return client.list_tags(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.list_tags(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, count = resp.tags.len(), "list_tags done");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn get_tag(
|
|
&self,
|
|
request: tonic::Request<GetTagRequest>,
|
|
) -> Result<tonic::Response<Tag>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let name = inner.name.clone();
|
|
let span = tracing::info_span!("tag.get_tag", %repo, %name);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_tag_client(self, inner.repository.as_ref(), false).await?
|
|
{
|
|
return client.get_tag(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.get_tag(inner).map_err(into_status)?;
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn create_tag(
|
|
&self,
|
|
request: tonic::Request<CreateTagRequest>,
|
|
) -> Result<tonic::Response<Tag>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let name = inner.name.clone();
|
|
let span = tracing::info_span!("tag.create_tag", %repo, %name);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_tag_client(self, inner.repository.as_ref(), true).await?
|
|
{
|
|
return client.create_tag(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.create_tag(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %name, "tag created");
|
|
self.notify_ref_update(&repo, &format!("refs/tags/{}", name), "", "");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn delete_tag(
|
|
&self,
|
|
request: tonic::Request<DeleteTagRequest>,
|
|
) -> Result<tonic::Response<()>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let name = inner.name.clone();
|
|
let span = tracing::info_span!("tag.delete_tag", %repo, %name);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_tag_client(self, inner.repository.as_ref(), true).await?
|
|
{
|
|
return client.delete_tag(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
gb.delete_tag(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %name, "tag deleted");
|
|
self.notify_ref_update(&repo, &format!("refs/tags/{}", name), "", "");
|
|
Ok(tonic::Response::new(()))
|
|
}
|
|
|
|
async fn verify_tag(
|
|
&self,
|
|
request: tonic::Request<VerifyTagRequest>,
|
|
) -> Result<tonic::Response<VerifiedSignature>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let name = inner.name.clone();
|
|
let span = tracing::info_span!("tag.verify_tag", %repo, %name);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_tag_client(self, inner.repository.as_ref(), false).await?
|
|
{
|
|
return client.verify_tag(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.verify_tag(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %name, verified = resp.verified, "tag verified");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
}
|