d243dce027
- Replaced manual remote client functions with remote_client! macro for archive, blame, branch, commit, and diff services - Simplified remote client creation logic using declarative macro approach - Maintained same functionality while reducing code duplication across services security(bare): enhance path traversal protection with comprehensive validation - Added early relative_path validation to prevent path traversal attacks - Implemented unified path validation to avoid TOCTOU race conditions - Enhanced canonicalization checks for both existing and non-existent paths - Added detailed logging for path traversal detection attempts feat(cache): migrate from CLruCache to Moka with TTL and invalidation support - Replaced clru dependency with moka for improved caching capabilities - Added 300-second time-to-live for cache entries - Implemented repository-specific cache invalidation mechanism - Enhanced cache operations with thread-safe async support refactor(commit): improve security validation for commit operations - Added ref name validation to prevent command injection in cherry_pick_commit - Implemented revision validation for commit selectors - Added comprehensive input validation for create_commit parameters - Enhanced file path validation to prevent traversal
141 lines
5.8 KiB
Rust
141 lines
5.8 KiB
Rust
use crate::pb::merge_service_client::MergeServiceClient;
|
|
use crate::pb::*;
|
|
|
|
use super::{GitksService, into_status};
|
|
|
|
remote_client!(remote_merge_client, MergeServiceClient<tonic::transport::Channel>, "merge");
|
|
|
|
#[tonic::async_trait]
|
|
impl merge_service_server::MergeService for GitksService {
|
|
async fn check_merge(
|
|
&self,
|
|
request: tonic::Request<CheckMergeRequest>,
|
|
) -> Result<tonic::Response<MergeResult>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let span = tracing::info_span!("merge.check_merge", %repo);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_merge_client(self, inner.repository.as_ref(), false).await?
|
|
{
|
|
return client.check_merge(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.check_merge(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, status = resp.status, "check_merge done");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn merge(
|
|
&self,
|
|
request: tonic::Request<MergeRequest>,
|
|
) -> Result<tonic::Response<MergeResult>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let target = inner.target_branch.clone();
|
|
let span = tracing::info_span!("merge.merge", %repo, %target);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_merge_client(self, inner.repository.as_ref(), true).await?
|
|
{
|
|
return client.merge(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.merge(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %target, status = resp.status, "merge done");
|
|
self.notify_ref_update(&repo, &format!("refs/heads/{}", target), "", "");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn list_merge_conflicts(
|
|
&self,
|
|
request: tonic::Request<ListMergeConflictsRequest>,
|
|
) -> Result<tonic::Response<ListMergeConflictsResponse>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let span = tracing::info_span!("merge.list_merge_conflicts", %repo);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_merge_client(self, inner.repository.as_ref(), false).await?
|
|
{
|
|
return client.list_merge_conflicts(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.list_merge_conflicts(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, conflicts = resp.conflicts.len(), "list_merge_conflicts done");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn resolve_merge_conflicts(
|
|
&self,
|
|
request: tonic::Request<ResolveMergeConflictsRequest>,
|
|
) -> Result<tonic::Response<MergeResult>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let target = inner.target_branch.clone();
|
|
let span = tracing::info_span!("merge.resolve_merge_conflicts", %repo, %target);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_merge_client(self, inner.repository.as_ref(), true).await?
|
|
{
|
|
return client.resolve_merge_conflicts(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.resolve_merge_conflicts(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %target, status = resp.status, "merge conflicts resolved");
|
|
self.notify_ref_update(&repo, &format!("refs/heads/{}", target), "", "");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
|
|
async fn rebase(
|
|
&self,
|
|
request: tonic::Request<RebaseRequest>,
|
|
) -> Result<tonic::Response<RebaseResult>, tonic::Status> {
|
|
let inner = request.into_inner();
|
|
let repo = self.repo_label(inner.repository.as_ref());
|
|
let branch = inner.branch.clone();
|
|
let span = tracing::info_span!("merge.rebase", %repo, %branch);
|
|
let _enter = span.enter();
|
|
let gb = match self.resolve(inner.repository.as_ref()) {
|
|
Ok(gb) => gb,
|
|
Err(err) if err.code() == tonic::Code::NotFound => {
|
|
if let Some(mut client) =
|
|
remote_merge_client(self, inner.repository.as_ref(), true).await?
|
|
{
|
|
return client.rebase(inner).await;
|
|
}
|
|
return Err(err);
|
|
}
|
|
Err(err) => return Err(err),
|
|
};
|
|
let resp = gb.rebase(inner).map_err(into_status)?;
|
|
tracing::info!(%repo, %branch, status = resp.status, "rebase done");
|
|
self.notify_ref_update(&repo, &format!("refs/heads/{}", branch), "", "");
|
|
Ok(tonic::Response::new(resp))
|
|
}
|
|
}
|