zhenyi
d243dce027
- Replaced manual remote client functions with remote_client! macro for archive, blame, branch, commit, and diff services - Simplified remote client creation logic using declarative macro approach - Maintained same functionality while reducing code duplication across services security(bare): enhance path traversal protection with comprehensive validation - Added early relative_path validation to prevent path traversal attacks - Implemented unified path validation to avoid TOCTOU race conditions - Enhanced canonicalization checks for both existing and non-existent paths - Added detailed logging for path traversal detection attempts feat(cache): migrate from CLruCache to Moka with TTL and invalidation support - Replaced clru dependency with moka for improved caching capabilities - Added 300-second time-to-live for cache entries - Implemented repository-specific cache invalidation mechanism - Enhanced cache operations with thread-safe async support refactor(commit): improve security validation for commit operations - Added ref name validation to prevent command injection in cherry_pick_commit - Implemented revision validation for commit selectors - Added comprehensive input validation for create_commit parameters - Enhanced file path validation to prevent traversal
51 lines
1.7 KiB
Rust
51 lines
1.7 KiB
Rust
use crate::bare::GitBare;
|
|
use crate::error::{GitError, GitResult};
|
|
use crate::pb::{CreateTagRequest, GetTagRequest, Tag};
|
|
|
|
impl GitBare {
|
|
pub fn create_tag(&self, request: CreateTagRequest) -> GitResult<Tag> {
|
|
crate::sanitize::validate_ref_name(&request.name)?;
|
|
let target = match request.target.and_then(|s| s.selector) {
|
|
Some(crate::pb::object_selector::Selector::Oid(oid)) => oid.hex,
|
|
Some(crate::pb::object_selector::Selector::Revision(name)) => {
|
|
crate::sanitize::validate_revision(&name.revision)?;
|
|
name.revision
|
|
}
|
|
None => "HEAD".into(),
|
|
};
|
|
let mut args = vec![
|
|
"--git-dir".to_string(),
|
|
self.bare_dir.to_string_lossy().into_owned(),
|
|
"tag".to_string(),
|
|
];
|
|
if request.force {
|
|
args.push("--force".into());
|
|
}
|
|
if request.annotated {
|
|
args.push("--annotate".into());
|
|
if !request.message.is_empty() {
|
|
args.push("-m".into());
|
|
args.push(request.message.clone());
|
|
}
|
|
}
|
|
args.push(request.name.clone());
|
|
args.push(target);
|
|
let result = duct::cmd("git", &args)
|
|
.stdout_capture()
|
|
.stderr_capture()
|
|
.unchecked()
|
|
.run()?;
|
|
if !result.status.success() {
|
|
return Err(GitError::CommandFailed {
|
|
status_code: result.status.code(),
|
|
stderr: String::from_utf8_lossy(&result.stderr).into_owned(),
|
|
});
|
|
}
|
|
self.get_tag(GetTagRequest {
|
|
repository: request.repository,
|
|
name: request.name,
|
|
include_raw: false,
|
|
})
|
|
}
|
|
}
|