feat(server): add tracing spans and caching to archive and blame services
- Add tracing spans with repo labels for archive and blame operations - Implement caching for archive list entries when using OID selectors - Implement caching for blame operations when using OID selectors - Add detailed
This commit is contained in:
+43
-5
@@ -1,6 +1,6 @@
|
||||
use crate::pb::*;
|
||||
|
||||
use super::{GitksService, into_status, into_stream};
|
||||
use super::{GitksService, cache, into_status, into_stream};
|
||||
|
||||
#[tonic::async_trait]
|
||||
impl diff_service_server::DiffService for GitksService {
|
||||
@@ -12,8 +12,18 @@ impl diff_service_server::DiffService for GitksService {
|
||||
request: tonic::Request<GetDiffRequest>,
|
||||
) -> Result<tonic::Response<GetDiffResponse>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("diff.get_diff", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let resp = gb.get_diff(inner).map_err(into_status)?;
|
||||
let resp = if cache::selectors_are_oid(&inner.base, &inner.head) {
|
||||
cache::cached_response("diff.get_diff", &inner, || {
|
||||
gb.get_diff(inner.clone()).map_err(into_status)
|
||||
})?
|
||||
} else {
|
||||
gb.get_diff(inner).map_err(into_status)?
|
||||
};
|
||||
tracing::info!(%repo, files = resp.files.len(), overflow = resp.overflow, "get_diff done");
|
||||
Ok(tonic::Response::new(resp))
|
||||
}
|
||||
|
||||
@@ -22,8 +32,18 @@ impl diff_service_server::DiffService for GitksService {
|
||||
request: tonic::Request<GetCommitDiffRequest>,
|
||||
) -> Result<tonic::Response<GetDiffResponse>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("diff.get_commit_diff", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let resp = gb.get_commit_diff(inner).map_err(into_status)?;
|
||||
let resp = if cache::selector_is_oid(&inner.commit) {
|
||||
cache::cached_response("diff.get_commit_diff", &inner, || {
|
||||
gb.get_commit_diff(inner.clone()).map_err(into_status)
|
||||
})?
|
||||
} else {
|
||||
gb.get_commit_diff(inner).map_err(into_status)?
|
||||
};
|
||||
tracing::info!(%repo, files = resp.files.len(), "get_commit_diff done");
|
||||
Ok(tonic::Response::new(resp))
|
||||
}
|
||||
|
||||
@@ -32,8 +52,17 @@ impl diff_service_server::DiffService for GitksService {
|
||||
request: tonic::Request<GetPatchRequest>,
|
||||
) -> Result<tonic::Response<Self::GetPatchStream>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("diff.get_patch", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let items = gb.get_patch(inner).map_err(into_status)?;
|
||||
let items = if cache::selectors_are_oid(&inner.base, &inner.head) {
|
||||
cache::cached_vec_response("diff.get_patch", &inner, || {
|
||||
gb.get_patch(inner.clone()).map_err(into_status)
|
||||
})?
|
||||
} else {
|
||||
gb.get_patch(inner).map_err(into_status)?
|
||||
};
|
||||
Ok(tonic::Response::new(into_stream(items)))
|
||||
}
|
||||
|
||||
@@ -42,8 +71,17 @@ impl diff_service_server::DiffService for GitksService {
|
||||
request: tonic::Request<GetDiffStatsRequest>,
|
||||
) -> Result<tonic::Response<DiffStats>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("diff.get_diff_stats", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let resp = gb.get_diff_stats(inner).map_err(into_status)?;
|
||||
let resp = if cache::selectors_are_oid(&inner.base, &inner.head) {
|
||||
cache::cached_response("diff.get_diff_stats", &inner, || {
|
||||
gb.get_diff_stats(inner.clone()).map_err(into_status)
|
||||
})?
|
||||
} else {
|
||||
gb.get_diff_stats(inner).map_err(into_status)?
|
||||
};
|
||||
Ok(tonic::Response::new(resp))
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user