feat(server): add tracing spans and caching to archive and blame services
- Add tracing spans with repo labels for archive and blame operations - Implement caching for archive list entries when using OID selectors - Implement caching for blame operations when using OID selectors - Add detailed
This commit is contained in:
+18
-4
@@ -1,6 +1,6 @@
|
||||
use crate::pb::*;
|
||||
|
||||
use super::{GitksService, into_status, into_stream};
|
||||
use super::{GitksService, cache, into_status};
|
||||
|
||||
#[tonic::async_trait]
|
||||
impl archive_service_server::ArchiveService for GitksService {
|
||||
@@ -12,9 +12,13 @@ impl archive_service_server::ArchiveService for GitksService {
|
||||
request: tonic::Request<ArchiveRequest>,
|
||||
) -> Result<tonic::Response<Self::GetArchiveStream>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("archive.get_archive", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let chunks = gb.get_archive(inner).map_err(into_status)?;
|
||||
Ok(tonic::Response::new(into_stream(chunks)))
|
||||
let stream = gb.get_archive_stream(inner)?;
|
||||
tracing::info!(%repo, "archive streaming started");
|
||||
Ok(tonic::Response::new(stream))
|
||||
}
|
||||
|
||||
async fn list_archive_entries(
|
||||
@@ -22,8 +26,18 @@ impl archive_service_server::ArchiveService for GitksService {
|
||||
request: tonic::Request<ListArchiveEntriesRequest>,
|
||||
) -> Result<tonic::Response<ListArchiveEntriesResponse>, tonic::Status> {
|
||||
let inner = request.into_inner();
|
||||
let repo = self.repo_label(inner.repository.as_ref());
|
||||
let span = tracing::info_span!("archive.list_archive_entries", %repo);
|
||||
let _enter = span.enter();
|
||||
let gb = self.resolve(inner.repository.as_ref())?;
|
||||
let resp = gb.list_archive_entries(inner).map_err(into_status)?;
|
||||
let resp = if cache::selector_is_oid(&inner.treeish) {
|
||||
cache::cached_response("archive.list_archive_entries", &inner, || {
|
||||
gb.list_archive_entries(inner.clone()).map_err(into_status)
|
||||
})?
|
||||
} else {
|
||||
gb.list_archive_entries(inner).map_err(into_status)?
|
||||
};
|
||||
tracing::info!(%repo, count = resp.entries.len(), "list_archive_entries done");
|
||||
Ok(tonic::Response::new(resp))
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user