refactor(cache): redesign cache system with structured keys and improved performance
- Add repo_path parameter to cached_response and cached_vec_response functions - Implement structured cache key format with namespace, repo_path, and request proto - Replace global cache with Moka in-memory cache using weight-based eviction - Set 256MB memory cap with 10-minute TTL and 2-minute TTI policy - Add metrics collection for cache operations and evictions - Implement efficient repo-scoped invalidation using key structure - Add detailed documentation comments explaining cache architecture - Remove outdated dependencies and update dependency versions - Add error handling for encoding failures in cache operations - Optimize Vec responses with length-delimited encoding and pre-allocation
This commit is contained in:
+15
-2
@@ -22,7 +22,11 @@ impl GitBare {
|
||||
|
||||
// Validate revision before spawning (cannot use ? inside spawn_blocking closure)
|
||||
let revision = match request.treeish.and_then(|s| s.selector) {
|
||||
Some(object_selector::Selector::Oid(oid)) => oid.hex,
|
||||
Some(object_selector::Selector::Oid(oid)) => {
|
||||
crate::sanitize::validate_oid_hex(&oid.hex)
|
||||
.map_err(|e| tonic::Status::invalid_argument(e.to_string()))?;
|
||||
oid.hex
|
||||
}
|
||||
Some(object_selector::Selector::Revision(name)) => {
|
||||
crate::sanitize::validate_revision(&name.revision)
|
||||
.map_err(|e| tonic::Status::invalid_argument(e.to_string()))?;
|
||||
@@ -31,9 +35,18 @@ impl GitBare {
|
||||
None => "HEAD".into(),
|
||||
};
|
||||
|
||||
let options = request.options.unwrap_or_default();
|
||||
if !options.prefix.is_empty() {
|
||||
crate::sanitize::validate_file_path(&options.prefix)
|
||||
.map_err(|e| tonic::Status::invalid_argument(e.to_string()))?;
|
||||
}
|
||||
for path in &options.pathspec {
|
||||
crate::sanitize::validate_file_path(path)
|
||||
.map_err(|e| tonic::Status::invalid_argument(e.to_string()))?;
|
||||
}
|
||||
|
||||
// Spawn the blocking git subprocess in a dedicated thread
|
||||
tokio::task::spawn_blocking(move || {
|
||||
let options = request.options.unwrap_or_default();
|
||||
let format = archive_options::Format::try_from(options.format)
|
||||
.unwrap_or(archive_options::Format::ArchiveFormatTar);
|
||||
let mut args = vec!["archive".to_string()];
|
||||
|
||||
@@ -2,8 +2,9 @@ use std::process::Command;
|
||||
|
||||
use crate::bare::GitBare;
|
||||
use crate::error::{GitError, GitResult};
|
||||
use crate::paginate;
|
||||
use crate::pb::{
|
||||
ArchiveEntry, ListArchiveEntriesRequest, ListArchiveEntriesResponse, ObjectType, PageInfo,
|
||||
ArchiveEntry, ListArchiveEntriesRequest, ListArchiveEntriesResponse, ObjectType,
|
||||
object_selector,
|
||||
};
|
||||
|
||||
@@ -13,7 +14,10 @@ impl GitBare {
|
||||
request: ListArchiveEntriesRequest,
|
||||
) -> GitResult<ListArchiveEntriesResponse> {
|
||||
let revision = match request.treeish.and_then(|s| s.selector) {
|
||||
Some(object_selector::Selector::Oid(oid)) => oid.hex,
|
||||
Some(object_selector::Selector::Oid(oid)) => {
|
||||
crate::sanitize::validate_oid_hex(&oid.hex)?;
|
||||
oid.hex
|
||||
}
|
||||
Some(object_selector::Selector::Revision(name)) => {
|
||||
crate::sanitize::validate_revision(&name.revision)?;
|
||||
name.revision
|
||||
@@ -22,8 +26,11 @@ impl GitBare {
|
||||
};
|
||||
let mut args = vec!["ls-tree".to_string(), "-r".into(), "-l".into(), revision];
|
||||
if !request.pathspec.is_empty() {
|
||||
for path in &request.pathspec {
|
||||
crate::sanitize::validate_file_path(path)?;
|
||||
}
|
||||
args.push("--".into());
|
||||
args.extend(request.pathspec);
|
||||
args.extend(request.pathspec.clone());
|
||||
}
|
||||
let output = Command::new("git")
|
||||
.arg("--git-dir")
|
||||
@@ -58,14 +65,10 @@ impl GitBare {
|
||||
})
|
||||
})
|
||||
.collect::<Vec<_>>();
|
||||
let total_count = entries.len() as u64;
|
||||
let (entries, page_info) = paginate::paginate(&entries, request.pagination.as_ref());
|
||||
Ok(ListArchiveEntriesResponse {
|
||||
entries,
|
||||
page_info: Some(PageInfo {
|
||||
next_page_token: String::new(),
|
||||
has_next_page: false,
|
||||
total_count,
|
||||
}),
|
||||
page_info: Some(page_info),
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user