refactor(bare): enhance security and performance optimizations
- Remove unnecessary sorting in advertise_refs for deterministic output - Add path traversal detection and validation in bare_dir construction - Implement symlink resolution checks to prevent security vulnerabilities - Refactor cache system with CRC validation and improved metrics - Integrate repo-specific cache invalidation using indexed keys - Add comprehensive unit tests for commit operations and diff functionality - Move configuration constants to centralized config module - Optimize string operations in disk cache random value generation - Enhance license detection algorithm with cleaner matching logic - Streamline argument processing in various git operations - Update dependencies including crc32fast and flate2 for performance - Add signal handling capability to tokio runtime configuration
This commit is contained in:
@@ -9,10 +9,8 @@ impl GitBare {
|
||||
|
||||
let base_args = build_rev_list_args(self, &request, &revision)?;
|
||||
|
||||
// 1. Get total count via rev-list --count (lightweight, no object parsing)
|
||||
let total = {
|
||||
let mut args = base_args.clone();
|
||||
// Insert after "rev-list" (index 2) so it's a rev-list flag, not a git flag
|
||||
args.insert(3, "--count".into());
|
||||
let result = duct::cmd("git", &args)
|
||||
.stdout_capture()
|
||||
@@ -31,7 +29,6 @@ impl GitBare {
|
||||
.unwrap_or(0)
|
||||
};
|
||||
|
||||
// 2. Apply git-side pagination: --skip + -n to only fetch the page
|
||||
let page_size = request
|
||||
.pagination
|
||||
.as_ref()
|
||||
@@ -52,7 +49,6 @@ impl GitBare {
|
||||
.min(total);
|
||||
|
||||
let mut fetch_args = base_args;
|
||||
// Insert after "rev-list" (index 2) so they are rev-list flags, not git flags
|
||||
fetch_args.insert(3, format!("--skip={start_offset}"));
|
||||
fetch_args.insert(4, format!("-n{page_size}"));
|
||||
|
||||
@@ -75,7 +71,6 @@ impl GitBare {
|
||||
.map(ToOwned::to_owned)
|
||||
.collect();
|
||||
|
||||
// 3. Batch-read commits via gix (one repo open, zero subprocess per commit)
|
||||
let commits = if page_ids.is_empty() {
|
||||
Vec::new()
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user